On Sat, Mar 11, 2023 at 9:58 PM Wouter Verhelst <w@xxxxxxx> wrote: > > Hi, > > On Thu, Jan 19, 2023 at 10:23:28PM +0800, Ming Lei wrote: > > The handshake implementation is borrowed from nbd project[2], so > > basically ublk-nbd just adds new code for implementing transmission > > phase, and it can be thought as moving linux block nbd driver into > > userspace. > [...] > > Any comments are welcome! > > I see you copied nbd-client.c and modified it, but removed all the > author information from it (including mine). > > Please don't do that. nbd-client is not public domain, it is GPLv2, > which means you need to keep copyright statements around somewhere. You > can move them into an AUTHORS file or some such if you prefer, but you > can't just remove them blindly. Thanks for finding it, and it must be one accident, and I will add the author info back soon. thanks,
