On Wednesday 08 March 2023 21:33:59 Sergey Shtylyov wrote:
> On 3/8/23 1:45 AM, Ondrej Zary wrote:
>
> > Remove Interface typedef, pass around struct pi_adapter * down to all
> > functions instead. Remove PPCSTRUCT define.
> >
> > Signed-off-by: Ondrej Zary <linux@xxxxxxx>
>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
>
> I had some nit tho -- see below...
>
> [...]
>
> > diff --git a/drivers/ata/pata_parport/bpck6.c b/drivers/ata/pata_parport/bpck6.c
> > index fa1f7d4fe3cb..bc128a2c444e 100644
> > --- a/drivers/ata/pata_parport/bpck6.c
> > +++ b/drivers/ata/pata_parport/bpck6.c
> [...]
> > static void bpck6_connect(struct pi_adapter *pi)
> > {
> > + struct ppc_storage *ppc = (void *)(pi->private);
>
> Parens around pi->private are unnecessary here and elsewhere...
>
> [...]
> > diff --git a/drivers/ata/pata_parport/ppc6lnx.c b/drivers/ata/pata_parport/ppc6lnx.c
> > index 5e5521d3b1dd..f12bb019fc61 100644
> > --- a/drivers/ata/pata_parport/ppc6lnx.c
> > +++ b/drivers/ata/pata_parport/ppc6lnx.c
> [...]
> > @@ -101,26 +101,27 @@ typedef struct ppc_storage {
> [...]
> > //***************************************************************************
> >
> > -static int ppc6_select(Interface *ppc)
> > +static int ppc6_select(struct pi_adapter *pi)
> > {
> > + struct ppc_storage *ppc = (void *)(pi->private);
>
> Parens around pi->private are unnecessary here and elsewhere...
Yes, missed that. But it's "fixed" in patch 9 by removing this code :)
--
Ondrej Zary
