On Mon, Mar 06, 2023 at 01:01:23PM +0100, Hannes Reinecke wrote:
> Convert the driver to work on folios instead of pages.
>
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
> ---
> drivers/block/brd.c | 171 ++++++++++++++++++++++----------------------
> 1 file changed, 85 insertions(+), 86 deletions(-)
>
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index 34177f1bd97d..7efc276c4963 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -28,8 +28,8 @@
> #include <linux/uaccess.h>
>
> /*
> - * Each block ramdisk device has a radix_tree brd_pages of pages that stores
> - * the pages containing the block device's contents. A brd page's ->index is
> + * Each block ramdisk device has a radix_tree brd_folios of folios that stores
^^^^^^^^^
> + * the folios containing the block device's contents. A brd folio's ->index is
^^^^^^^^^^
So we end up with:
"a radix_tree brd_folios of folios that stores the folios containing ..."
What about:
"a radix_tree brd_folios that stores folios containing"
Other than that, looks good:
Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
So another thing, I think I counted about 5-8 grammatical rules which
could be bundled up into *one* SmPL grammar patch which could then be
used to automatically do similar tasks elsewhere.
Luis
