Re: [PATCH blktests] src/Makefile: fix number sign handling in macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mar 02, 2023 / 05:02, Chaitanya Kulkarni wrote:
> On 3/1/2023 12:03 AM, Shin'ichiro Kawasaki wrote:
> > GNU make version 4.3 introduced a backward-incompatible change. The
> > number sign '#' now should not have preceding backslash in a macro [1].
> > To make macros with number signs work regardless of make versions,
> > assign the number sign to a variable.
> > 
> > [1] https://lwn.net/Articles/810071/
> > 
> > Reported-by: Ziyang Zhang <ZiyangZhang@xxxxxxxxxxxxxxxxx>
> > Link: https://lore.kernel.org/linux-block/cfccc895-5a9b-f45b-5851-74c94219d743@xxxxxxxxxxxxxxxxx/
> > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> > ---
> > This patch can be applied on top of Ming Lei's series for miniublk [2].
> > 
> > [2] https://lore.kernel.org/linux-block/20230224124502.1720278-1-ming.lei@xxxxxxxxxx/
> 
> 
> Looks good. I've reviewed Ming's ublk series, feel free to add this one
> too.
> 
> Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

Thanks, I've merged this together with the ublk series.

-- 
Shin'ichiro Kawasaki



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux