On Thu, Feb 23, 2023 at 12:34:46PM -0700, Uday Shankar wrote: > I chose to add blk_queue_get_max_segments as a public function because > it parallels blk_queue_get_max_sectors. If you don't want two functions, > I could manually inline the (2) uses of blk_rq_get_max_segments(rq), > converting them to blk_queue_get_max_segments(rq->q, req_op(rq)). I'd be much happier with a single function that takes a request instead of two decoded arguments. This should not be a public API in any form.