Re: [PATCH] block: shift with PAGE_SHIFT instead of dividing with PAGE_SIZE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023-02-22 20:57, Bart Van Assche wrote:
> On 2/22/23 06:34, Pankaj Raghav wrote:
>> No functional change. Division will be costly, especially in the hot
>> path (page_is_mergeable() and bio_copy_user_iov())
> 
> Although the change looks fine to me, is there any compiler for which this
> patch makes a difference? I would expect that a compiler performs this
> optimization even without this patch.
>

I didn't notice any for x86_64. But I was thinking this also as a way to
maintain consistency across block code where we do a shift with PAGE_SHIFT
instead of dividing with PAGE_SIZE.

> Thanks,
> 
> Bart.
> 



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux