I don't think that those are particular important to clean up - but a couple of the other checkpatch warnings were On Fri, Feb 17, 2023 at 2:08 AM David Howells <dhowells@xxxxxxxxxx> wrote: > > Steve French <smfrench@xxxxxxxxx> wrote: > > > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > > #627: FILE: fs/cifs/file.c:2609: > > +#if 0 // TODO: Remove for iov_iter support > > ... > > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > > #1040: FILE: fs/cifs/file.c:3512: > > +#if 0 // TODO: Remove for iov_iter support > > > > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > > #1067: FILE: fs/cifs/file.c:3587: > > +#if 0 // TODO: Remove for iov_iter support > > > > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > > #1530: FILE: fs/cifs/file.c:4217: > > +#if 0 // TODO: Remove for iov_iter support > > > > WARNING: Consider removing the code enclosed by this #if 0 and its #endif > > #1837: FILE: fs/cifs/file.c:4903: > > +#if 0 // TODO: Remove for iov_iter support > > These chunks of code are removed in patch 16. I did it this way to reduce the > size of patch 14. I can merge 16 into 14 if you like. > > David > -- Thanks, Steve
