On Thu, Feb 16, 2023 at 08:35:20AM +0000, Shinichiro Kawasaki wrote: > On Feb 16, 2023 / 11:01, Ming Lei wrote: > > Hello, > > > > The 1st patch adds one mini ublk program, which only supports null & > > loop targets. > > > > The 2nd patch add blktests/033 for covering gendisk leak issue. > > > > Ming Lei (2): > > blktests/src: add mini ublk source code > > blktests/033: add test to cover gendisk leak > > Hi Ming, thanks for the patches. Please find my comments on them. > Also, could you run "make check" for the blktests patches? Shellcheck reported > some warnings in the changes. > > $ make check > shellcheck -x -e "" -f gcc check new common/* \ > tests/*/rc tests/*/[0-9]*[0-9] > common/ublk:19:52: warning: args is referenced but not assigned. [SC2154] > tests/block/033:27:8: warning: Declare and assign separately to avoid masking return values. [SC2155] > tests/block/033:27:17: note: Use $(...) notation instead of legacy backticks `...`. [SC2006] > tests/block/033:28:24: note: Double quote to prevent globbing and word splitting. [SC2086] Thanks for sharing the check command! Will run check and fix them all in V2. Thanks, Ming
