On Feb 10, 2023 / 16:42, Kanchan Joshi wrote:
> On Fri, Feb 10, 2023 at 02:01:14AM +0000, Shinichiro Kawasaki wrote:
[...]
> > If you don't mind, I can create another patch for further discussion based on
> > the suggestion above, and modify your patch to use the new helper functions.
> Sure. Please remove "_have_fio" line also in v2.
Okay. I've sent out v2 [1]. Please check and confirm that it works for you.
FYI, I did a couple of more nit edits:
- No need to call _require_test_dev_is_nvme, since it is called from
group_device_requires in tests/nvme/rc.
- Separated local variable declarations and initialization. ('make check'
reported shellcheck complaints about it.)
[1] https://lore.kernel.org/linux-block/20230214044739.1903364-1-shinichiro.kawasaki@xxxxxxx/
--
Shin'ichiro Kawasaki
