Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > Also why doesn't this use init_sync_kiocb? I'm not sure I want ki_flags. > > if (in->f_flags & O_DIRECT) > > return generic_file_direct_splice_read(in, ppos, pipe, len, flags); > > + return generic_file_buffered_splice_read(in, ppos, pipe, len, flags); > > Btw, can we drop the verbose generic_file_ prefix here? Probably. Note that at some point cifs, for example, running in "unbuffered" mode might want to call [generic_file_]direct_splice_read() directly. David
