On Thu, Feb 09, 2023 at 06:04:01AM +0100, Christoph Hellwig wrote: > On Thu, Feb 09, 2023 at 07:47:38AM +0800, Ming Lei wrote: > > Another thing is that blkcg_init_disk() and blkcg_exit_disk() becomes > > asymmetrical with this patch. So alloc_disk() & add_disk(), del_disk() & put_disk() > > have to be done together. If it may be documented, this patch looks > > fine. > > As in no add_disk is allowed after del_gendisk on the same disk? > It's been like that since basically forever. I agree that documenting > it probably doesn't hurt though - but that's separate from this fix. OK, fair enough, Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx> Thanks, Ming
