On Thu, Feb 09, 2023 at 11:19:30AM +0800, Xiao Ni wrote: > It checks if plug->cached_rq is empty before merging bio. But the merge action > doesn't have relationship with plug->cached_rq, it trys to merge bio with > requests within plug->mq_list. Now it checks if ->cached_rq is empty before > merging bio. If it's empty, it will miss the merge chances. So move the merge > function before checking ->cached_rq. > > Signed-off-by: Xiao Ni <xni@xxxxxxxxxx> > --- > block/blk-mq.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Looks fine, Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx> Thanks, Ming
