[bug report] blk-cgroup: simplify blkg freeing from initialization failure paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Christoph Hellwig,

The patch 27b642b07a4a: "blk-cgroup: simplify blkg freeing from
initialization failure paths" from Feb 3, 2023, leads to the
following Smatch static checker warning:

block/blk-cgroup.c:762 blkg_conf_prep() warn: sleeping in atomic context
block/blk-cgroup.c:769 blkg_conf_prep() warn: sleeping in atomic context
blkg_conf_prep() 
	[ takes a lock and calls blkg_free() in the same function. ]

block/blk-cgroup.c:387 blkg_create() warn: sleeping in atomic context
blkg_lookup_create() <- disables preempt
blkg_conf_prep() <- disables preempt
blkcg_init_disk() <- disables preempt
-> blkg_create()

	[ The first call tree is a false positive but blkg_conf_prep()
          and blkcg_init_disk() have issues. ]

regards,
dan carpenter



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux