Hello Christoph Hellwig, The patch 27b642b07a4a: "blk-cgroup: simplify blkg freeing from initialization failure paths" from Feb 3, 2023, leads to the following Smatch static checker warning: block/blk-cgroup.c:762 blkg_conf_prep() warn: sleeping in atomic context block/blk-cgroup.c:769 blkg_conf_prep() warn: sleeping in atomic context blkg_conf_prep() [ takes a lock and calls blkg_free() in the same function. ] block/blk-cgroup.c:387 blkg_create() warn: sleeping in atomic context blkg_lookup_create() <- disables preempt blkg_conf_prep() <- disables preempt blkcg_init_disk() <- disables preempt -> blkg_create() [ The first call tree is a false positive but blkg_conf_prep() and blkcg_init_disk() have issues. ] regards, dan carpenter