On Tue, Feb 7, 2023 at 9:53 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> It's a false positive. See the comment above fscrypt_destroy_keyring()
Hmm. Ok. Unfortunate.
> If the filesystem has not been mounted, then the call from __put_super()
> is needed, but blk_crypto_evict_key() can never be executed in that case.
It's not all that clear that some *other* error might not have
happened to keep the mount from actually succeeding, but after the
keys have been instantiated?
IOW, what's the thing that makes "blk_crypto_evict_key() can never be
executed in that case" be obvious?
I think _that_ is what might want a comment, about how we always call
generic_shutdown_super() before the last put_super() happens.
It does seem like Dan's automated checks could be useful, but if
there's no sane way to avoid the false positives, it's always going to
be a lot of noise ;(
Linus
