Re: [PATCH RESEND 1/3] ublk: remove unnecessary NULL check in ublk_rq_has_data()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ziyang Zhang <ZiyangZhang@xxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH RESEND 1/3] ublk: remove unnecessary NULL check in ublk_rq_has_data()
From: Ming Lei <ming.lei@xxxxxxxxxx>
Date: Tue, 7 Feb 2023 22:06:27 +0800
Cc: axboe@xxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, joseph.qi@xxxxxxxxxxxxxxxxx
In-reply-to: <20230207070839.370817-2-ZiyangZhang@linux.alibaba.com>
References: <20230207070839.370817-1-ZiyangZhang@linux.alibaba.com> <20230207070839.370817-2-ZiyangZhang@linux.alibaba.com>

On Tue, Feb 07, 2023 at 03:08:37PM +0800, Ziyang Zhang wrote:
> bio_has_data() allows a NULL bio so the NULL check in
> ublk_rq_has_data() is unnecessary.
> 
> Signed-off-by: Ziyang Zhang <ZiyangZhang@xxxxxxxxxxxxxxxxx>

Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>


Thanks,
Ming

References:
- [PATCH RESEND 0/3] cleanup for ublk
  - From: Ziyang Zhang
- [PATCH RESEND 1/3] ublk: remove unnecessary NULL check in ublk_rq_has_data()
  - From: Ziyang Zhang

Prev by Date: block: sleeping in atomic warnings
Next by Date: Re: [PATCH RESEND 2/3] ublk: mention WRITE_ZEROES in comment of ublk_complete_rq()
Previous by thread: [PATCH RESEND 1/3] ublk: remove unnecessary NULL check in ublk_rq_has_data()
Next by thread: [PATCH RESEND 3/3] ublk: pass NULL to blk_mq_alloc_disk() as queuedata
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux