On Tuesday 31 January 2023, Damien Le Moal wrote: > On 1/31/23 06:10, Ondrej Zary wrote: > > diff --git a/drivers/Makefile b/drivers/Makefile > > index f1365608bc8c..de8aa561c95c 100644 > > --- a/drivers/Makefile > > +++ b/drivers/Makefile > > @@ -98,7 +98,7 @@ obj-$(CONFIG_DIO) += dio/ > > obj-$(CONFIG_SBUS) += sbus/ > > obj-$(CONFIG_ZORRO) += zorro/ > > obj-$(CONFIG_ATA_OVER_ETH) += block/aoe/ > > -obj-y += block/paride/ > > +obj-$(CONFIG_PATA_PARPORT) += ata/pata_parport/ > > It would be better to have this in drivers/ata/Makefile, not here, so that doing > something like: > > make -j64 M=drivers/ata W=1 > or > make -j64 M=drivers/ata C=1 > > actually also checks the parport protocol modules too. > > diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile > index 23588738cff0..2f85812e16ef 100644 > --- a/drivers/ata/Makefile > +++ b/drivers/ata/Makefile > @@ -114,6 +114,7 @@ obj-$(CONFIG_PATA_SAMSUNG_CF) += pata_samsung_cf.o > > obj-$(CONFIG_PATA_PXA) += pata_pxa.o > > +obj-$(CONFIG_PATA_PARPORT) += pata_parport/ > obj-$(CONFIG_PATA_PARPORT) += pata_parport.o > > And then we could also have drivers/ata/pata_parport.c moved under > drivers/ata/pata_parport/ to tidy things up. > > If you agree, I can fix that up, that is easy to do. OK, thank you. -- Ondrej Zary
