Hello,
On Tue, Jan 24, 2023 at 07:57:04AM +0100, Christoph Hellwig wrote:
> @@ -245,10 +245,9 @@ static struct blkcg_gq *blkg_alloc(struct blkcg *blkcg, struct gendisk *disk,
> if (!blkg->iostat_cpu)
> goto err_free;
>
> - if (!blk_get_queue(disk->queue))
> - goto err_free;
> + get_device(disk_to_dev(disk));
We lose the blk_queue_dying() test here. It'd be great if the patch
description explains why this is safe.
> @@ -547,9 +546,7 @@ static int blkcg_reset_stats(struct cgroup_subsys_state *css,
>
> const char *blkg_dev_name(struct blkcg_gq *blkg)
> {
> - if (!blkg->q->disk || !blkg->q->disk->bdi->dev)
> - return NULL;
> - return bdi_dev_name(blkg->q->disk->bdi);
> + return bdi_dev_name(blkg->disk->bdi);
This isn't completely trivial like other conversions. Maybe worth mentioning
in the description too?
Thanks.
--
tejun
