On 1/25/23 6:34 AM, Christoph Hellwig wrote: > Hi all, > > this series removes the ->rw_page block_device_operation, which is an old > and clumsy attempt at a simple read/write fast path for the block layer. > It isn't actually used by the fastest block layer operations that we > support (polled I/O through io_uring), but only used by the mpage buffered > I/O helpers which are some of the slowest I/O we have and do not make any > difference there at all, and zram which is a block device abused to > duplicate the zram functionality. Given that zram is heavily used we > need to make sure there is a good replacement for synchronous I/O, so > this series adds a new flag for drivers that complete I/O synchronously > and uses that flag to use on-stack bios and synchronous submission for > them in the swap code. This is great, thanks for doing it. There's no reason for this weird rw_page interface to exist. -- Jens Axboe