On Tue, Jan 24, 2023 at 09:17:57PM +0000, David Howells wrote: > John Hubbard <jhubbard@xxxxxxxxxx> wrote: > > > > + /* for now require references for all pages */ > > > > Maybe just delete this comment? > > Christoph added that. Presumably because this really should move to pinning > or be replaced with iomap, but it's not straightforward either way. Christoph? Mostly because it adds the flag when allocating the bio, and not where doing the gup. If John thinks it adds more confusion than it helps, we can drop the comment. That being said you had a conversion in an earlier version of the series, and once the current batch of patches is in we should resurrected it ASAP as that will allow us to kill BIO_FLAG_REFFED.
