On Mon, Jan 23, 2023 at 08:53:56AM +0100, Christoph Hellwig wrote:
Hi Christoph,
> s390 iterates over the bio using bio_for_each_segment and doesn't need
> any bio splitting.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> drivers/s390/block/dcssblk.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c
> index c0f85ffb2b62de..c09f2e053bf863 100644
> --- a/drivers/s390/block/dcssblk.c
> +++ b/drivers/s390/block/dcssblk.c
> @@ -864,10 +864,6 @@ dcssblk_submit_bio(struct bio *bio)
> unsigned long source_addr;
> unsigned long bytes_done;
>
> - bio = bio_split_to_limits(bio);
> - if (!bio)
> - return;
> -
> bytes_done = 0;
> dev_info = bio->bi_bdev->bd_disk->private_data;
> if (dev_info == NULL)
If my understanding is correct that this change was as good as
early as commit 54efd50bfd87 ("block: make generic_make_request
handle arbitrarily sized bios") took place and simply fell into
the second category?
...
Some make_request_fn() callbacks were simple enough to audit and verify
they don't need blk_queue_split() calls. The skipped ones are:
...
Some others are almost certainly safe to remove now, but will be left
for future patches.
...
Thanks!
