On 21.01.23 07:51, Christoph Hellwig wrote: > Currently btrfs handles checksum validation and repair in the end I/O > handler for the btrfs_bio. This leads to a lot of duplicate code > plus issues with variying semantics or bugs, e.g. s/variying/varying > buffered I/O this now means that a large readahead request can > fail due to a single bad sector, but as readahead errors are igored s/igored/ignored/ > the following readpage if the sector is actually accessed will s/if/of > still be able to read. This also matches the I/O failure handling > in other file systems. Sorry for not having spotted these earlier. Anyways, code still looks good: Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>