On Sun, Jan 22, 2023 at 01:49:00PM -0700, Jens Axboe wrote: > On 1/22/23 8:49 AM, Tom Rix wrote: > > clang static analysis reports > > drivers/block/paride/pcd.c:856:36: warning: The left operand of '&' > > is a garbage value [core.UndefinedBinaryOperatorResult] > > tocentry->cdte_ctrl = buffer[5] & 0xf; > > ~~~~~~~~~ ^ > > Has this one been compiled? I'm guessing not tested... > > In any case, this code is going away hopefully shortly, so let's not > bother with changes like this. Look at the callers - the value left in entry is discarded if ->audio_ioctl(..., CDROMREADTOCENTRY, &entry) returns non-zero. Sure, it's a nasal daemon territory, but realistically it's not going to be caught by testing.
