Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 18 Jan 2023 21:45:14 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <Y8hyjEw94LIZ84xo@ZenIV>
References: <167391047703.2311931.8115712773222260073.stgit@warthog.procyon.org.uk> <167391052497.2311931.9463379582932734164.stgit@warthog.procyon.org.uk> <Y8ZVGEvbVsf4eDNU@infradead.org> <Y8hyjEw94LIZ84xo@ZenIV>

On Wed, Jan 18, 2023 at 10:28:28PM +0000, Al Viro wrote:
> On Mon, Jan 16, 2023 at 11:58:16PM -0800, Christoph Hellwig wrote:
> > On Mon, Jan 16, 2023 at 11:08:44PM +0000, David Howells wrote:
> > > Use the direction in the iterator functions rather than READ/WRITE.
> > 
> > I don't think we need the direction at all as nothing uses it any more.
> 
> ... except for checks in copy_from_iter() et.al.

Debug checks, yes.

References:
- [PATCH v6 00/34] iov_iter: Improve page extraction (ref, pin or just list)
  - From: David Howells
- [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions
  - From: David Howells
- Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions
  - From: Christoph Hellwig
- Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions
  - From: Al Viro

Prev by Date: Re: [PATCH v6 01/34] vfs: Unconditionally set IOCB_WRITE in call_write_iter()
Next by Date: Re: [PATCH v6 03/34] iov_iter: Pass I/O direction into iov_iter_get_pages*()
Previous by thread: Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions
Next by thread: Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]