on 1/19/2023 1:37 AM, Christoph Hellwig wrote: > On Wed, Jan 18, 2023 at 05:37:19PM +0800, Kemeng Shi wrote: >> +/* >> + * blk_mq_commit_rqs will notify driver using bd->last that there is no >> + * more requests. (See comment in struct blk_mq_ops for commit_rqs for >> + * details) >> + * Attention, we should explicitly call this in unusual cases: >> + * 1) did not queue everything initially scheduled to queue >> + * 2) the last attempt to queue a request failed >> + */ >> +static void blk_mq_commit_rqs(struct blk_mq_hw_ctx *hctx, int queued, >> + bool from_schedule) > > Isn't from_schedule always false here as well now? Hi Christoph , Yes, it's always false now. As blk_mq_commit_rqs is a general function for all commits now, I keep the from_schedule for commits where from_schedule maybe true in future. We can remove from_schedule now and add it back when from_schedule is indeed needed. Both way is acceptable for me. Please let me know which way do you prefer and I will send a new version if needed. Thanks. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > -- Best wishes Kemeng Shi
