Re: [PATCH] blk-cgroup: fix missing pd_online_fn() while activating policy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Jens

在 2023/01/03 19:28, Yu Kuai 写道:
From: Yu Kuai <yukuai3@xxxxxxxxxx>

If the policy defines pd_online_fn(), it should be called after
pd_init_fn(), like blkg_create().

Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>

Can you apply this patch?

Thanks,
Kuai
---
  block/blk-cgroup.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index ce6a2b7d3dfb..4c94a6560f62 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -1455,6 +1455,10 @@ int blkcg_activate_policy(struct request_queue *q,
  		list_for_each_entry_reverse(blkg, &q->blkg_list, q_node)
  			pol->pd_init_fn(blkg->pd[pol->plid]);
+ if (pol->pd_online_fn)
+		list_for_each_entry_reverse(blkg, &q->blkg_list, q_node)
+			pol->pd_online_fn(blkg->pd[pol->plid]);
+
  	__set_bit(pol->plid, q->blkcg_pols);
  	ret = 0;




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux