On Mon, Jan 16, 2023 at 09:07:00AM +0800, Kemeng Shi wrote: > >> Why? I think always having the trace even for the commit case seems > >> very useful for making the traces useful. > > I think unplug event more likely means that request going to be sent to driver > > was plugged and in plug list. And the current code do only trace unplug event > > when dispatching requests from plug list. If so, would it be better to add > > a new event to trace commit? > Hi Christoph, which way do you prefer now? Keep unplug event consistent to > trace commit of requests from plug list only or trace all commits with > unplug event. Please let me know and I will consider it in next version. > Thanks. To me always having the trace feels more useful, but let's see if Jens has an opinion on it.
