Re: [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available rather than iterator direction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available rather than iterator direction
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Fri, 13 Jan 2023 20:33:13 -0500
Cc: Bart Van Assche <bart.vanassche@xxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Douglas Gilbert <dgilbert@xxxxxxxxxxxx>
In-reply-to: <Y8Ds9JbWNGlWnoj9@infradead.org> (Christoph Hellwig's message of "Thu, 12 Jan 2023 21:32:36 -0800")
Organization: Oracle Corporation
References: <Y7+8r1IYQS3sbbVz@infradead.org> <167344725490.2425628.13771289553670112965.stgit@warthog.procyon.org.uk> <167344727810.2425628.4715663653893036683.stgit@warthog.procyon.org.uk> <15330.1673519461@warthog.procyon.org.uk> <Y8AUTlRibL+pGDJN@infradead.org> <Y8BFVgdGYNQqK3sB@ZenIV> <c6f4014e-d199-d5e8-515c-5ffcd9946c80@gmail.com> <Y8Ds9JbWNGlWnoj9@infradead.org>

Christoph,

> Yeah.  And that weird (ab)use of blk_rq_map_user_iov into preallocated
> pages in sg has been a constant source of pain.  I'd be very happy to
> make it match the generic SG_IO implementation and either do
> get_user_pages or the normal bounce buffering implemented in the
> common code.

Yes, it would be nice to get that cleaned up.

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- Re: [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available rather than iterator direction
  - From: Christoph Hellwig
- [PATCH v5 0/9] iov_iter: Add extraction helpers
  - From: David Howells
- [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available rather than iterator direction
  - From: David Howells
- Re: [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available rather than iterator direction
  - From: David Howells
- Re: [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available rather than iterator direction
  - From: Christoph Hellwig
- Re: [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available rather than iterator direction
  - From: Al Viro
- Re: [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available rather than iterator direction
  - From: Bart Van Assche
- Re: [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available rather than iterator direction
  - From: Christoph Hellwig

Prev by Date: Re: [GIT PULL] Block fixes for 6.2-rc4
Next by Date: Re: [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available rather than iterator direction
Previous by thread: Re: [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available rather than iterator direction
Next by thread: Re: [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available rather than iterator direction
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]