On Wed, Jan 11, 2023 at 02:27:58PM +0000, David Howells wrote: > If a kiocb or iomap_iter is available, then use the IOCB_WRITE flag or the > IOMAP_WRITE flag to determine whether we're writing rather than the > iterator direction flag. > > This allows all but three of the users of iov_iter_rw() to be got rid of: a > consistency check and a warning statement in cifs and one user in the block > layer that has neither available. > > Signed-off-by: David Howells <dhowells@xxxxxxxxxx> > cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > Link: https://lore.kernel.org/r/167305163159.1521586.9460968250704377087.stgit@xxxxxxxxxxxxxxxxxxxxxx/ # v4 Incidentally, I'd suggest iocb_is_write(iocb) - just look at the amount of places where you end up with clumsy parentheses...