On Wed, Jan 04, 2023 at 09:09:38AM -0700, Jens Axboe wrote: > split: > + /* > + * We can't sanely support splitting for a REQ_NOWAIT bio. End it > + * with EAGAIN if splitting is required and return an error pointer. > + */ > + if (bio->bi_opf & REQ_NOWAIT) { > + bio->bi_status = BLK_STS_AGAIN; > + bio_endio(bio); > + return ERR_PTR(-EAGAIN); > + } Hmm. Just completing the bio here seems a little dangerous in terms of ownership. What speaks against letting the caller do it?