>> + >> + if [ -z "$fail" ]; then >> + echo "Test complete" >> + else >> + echo "Test failed" >> + return 1 >> + fi > I see that several test have this structure, but would it not be better > to do: > > """ > if [ -n "$fail" ]; then > echo "Test failed" > return 1 > fi > > return "Test complete" > """ > > I point this out because I noticed that most nvme tests just set the > "test complete" string at the end of the test function. > Yes, "Test complete" is sufficient to validate the correctness and keeps the code small. -ck
