> enum blk_default_limits { > BLK_MAX_SEGMENTS = 128, > BLK_SAFE_MAX_SECTORS = 255, > - BLK_DEF_MAX_SECTORS = 2560, > BLK_MAX_SEGMENT_SIZE = 65536, > BLK_SEG_BOUNDARY_MASK = 0xFFFFFFFFUL, > }; Looking at the enum all these really should be unsigned values anyway, so we might as well keep the enum. Either way this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>