On Thu, Dec 22, 2022 at 09:40:11AM +0100, Christoph Hellwig wrote:
> On Thu, Dec 22, 2022 at 04:32:10PM +0800, kernel test robot wrote:
> > >> block/blk-settings.c:138:49: warning: comparison of distinct pointer types ('typeof (limits->max_sectors) *' (aka 'unsigned int *') and 'typeof (BLK_DEF_MAX_SECTORS) *' (aka 'int *')) [-Wcompare-distinct-pointer-types]
>
> Yeah, that's not going to work. BLK_DEF_MAX_SECTORS should probably
> become an unsigned constant to fix this.
Hm, I should have used max_t() instead of max().
But thinking on this again, we probably want to respect the user setting
even if it's lower than the default too, not just if its larger. I
believe that will require a new queue limit to save that value.
