On Wed, Dec 21, 2022 at 10:46 PM Suwan Kim <suwan.kim027@xxxxxxxxx> wrote: > > On Wed, Dec 21, 2022 at 02:48:30AM -0800, Christoph Hellwig wrote: > > > + if (likely(!blk_should_fake_timeout(req->q)) && > > > + !blk_mq_complete_request_remote(req) && > > > + !blk_mq_add_to_batch(req, iob, vbr->status, > > > + virtblk_complete_batch)) > > > > One tab indents for line continuations are really confusing. Please > > make this: > > > > if (likely(!blk_should_fake_timeout(req->q)) && > > !blk_mq_complete_request_remote(req) && > > !blk_mq_add_to_batch(req, iob, vbr->status, > > virtblk_complete_batch)) > > > > > + found = virtblk_handle_req(vq, iob); > > > > > > if (found) > > > > You can drop the found variable here now: > > > > if (virtblk_handle_req(vq, iob)) > > blk_mq_start_stopped_hw_queues(vblk->disk->queue, true); > > > Ah, virtblk_poll() should return found to indicate whether a request was processed. I'll leave this as is. Regards, Suwan Kim
