On 11/25/22 09:34, Douglas Gilbert wrote:
On 2022-11-23 15:57, Bart Van Assche wrote:
module_param_named(no_uld, sdebug_no_uld, int, S_IRUGO);
+module_param_named(max_segment_size, sdebug_max_segment_size, uint,
S_IRUGO);
Could you place the above line in alphabetical order.
module_param_named(num_parts, sdebug_num_parts, int, S_IRUGO);
module_param_named(num_tgts, sdebug_num_tgts, int, S_IRUGO | S_IWUSR);
module_param_named(opt_blks, sdebug_opt_blks, int, S_IRUGO);
@@ -7815,6 +7817,7 @@ static int sdebug_driver_probe(struct device *dev)
sdebug_driver_template.can_queue = sdebug_max_queue;
sdebug_driver_template.cmd_per_lun = sdebug_max_queue;
+ sdebug_driver_template.max_segment_size = sdebug_max_segment_size;
if (!sdebug_clustering)
sdebug_driver_template.dma_boundary = PAGE_SIZE - 1;
And could you add a
MODULE_PARM_DESC(max_segment_size, "<1 line description>");
entry as well (also in alphabetical order).
Hi Doug,
I will make these changes.
Thanks for the feedback.
Bart.
