On 11/29/22 7:28 AM, Keith Busch wrote: > On Mon, Oct 03, 2022 at 12:43:43PM +0300, Sagi Grimberg wrote: >> >> +void nvme_start_request(struct request *rq) >> +{ >> + blk_mq_start_request(rq); >> +} >> +EXPORT_SYMBOL_GPL(nvme_start_request); > > Looks good, other than I feel this should be a static inline function in > nvme.h instead. Hah, mid-air collision. But at least we agree :-) -- Jens Axboe