on 11/24/2022 2:28 AM, Tejun Heo wrote: > On Wed, Nov 23, 2022 at 02:03:58PM +0800, Kemeng Shi wrote: >> static bool throtl_hierarchy_can_downgrade(struct throtl_grp *tg) >> { >> + if (time_before(now, tg->td->low_upgrade_time + td->throtl_slice)) >> + return false; > > Does this even build? Where is td defined? Sorry for this mistake, CONFIG_BLK_DEV_THROTTLING_LOW seems not be set on default. I will fix this and build with CONFIG_BLK_DEV_THROTTLING_LOW set. -- Best wishes Kemeng Shi