on 11/24/2022 1:11 AM, Tejun Heo wrote: > On Wed, Nov 23, 2022 at 02:03:51PM +0800, Kemeng Shi wrote: >> Quoted from comment in throtl_pd_init: "If on the default hierarchy, we >> switch to properly hierarchical behavior where limits on a given >> throtl_grp are applied to the whole subtree rather than just the group >> itself. e.g. If 16M read_bps limit is set on the root group, the whole >> system can' exceed 16M for the device." > > On the default hierarchy (cgroup2), the throttle interface files don't exist > in the root cgroup. In general, cgroup doesn't wanna be in the business of > restricting resources at the system level. Hi, Tejun. Thanks for review. If restricting is not needed anymore, the stale comment "e.g. If 16M read_bps limit is set on the root group, the whole system can' exceed 16M for the device." may better be remove. I will remove this in next version. -- Best wishes Kemeng Shi
