On Sat, Nov 19, 2022 at 02:19:43AM +0000, Al Viro wrote: > > Changes since v1: > > - also change the blk_crypto_sysfs_unregister prototype > > - add two patches to fix the error handling in blk_register_queue > > Umm... Do we ever want access to queue parameters of the stuff that has > a queue, but no associated gendisk? SCSI tape, for example... What do you mean with "access queue parameters"? The sysfs access can since day one only happen through the queue. > Re refcounting: AFAICS, blk_mq_alloc_disk_for_queue() is broken. > __alloc_disk_node() consumes queue reference (and stuffs it into gendisk->queue) > on success; on failure it leaves the reference alone. E.g. this Yes, it needs a put_queue for the error handler.
