On Nov 15, 2022 / 16:12, Alan Adamson wrote:
> Commit d7ac8dca938c ("nvme: quiet user passthrough command errors")
> disabled error logging for passthrough commands so the associated
> error output in nvme/039.out should be removed.
>
> When an error logging opt-in mechanism for passthrough commands is
> provided, the error output can be added back.
Thanks for this quick action. This two-steps approach looks good for me.
I confirmed the fix avoids the failure with v6.1-rc5 kernel. Also, I observe
this fix makes the test case fail with v6.0 kernel. I suggest to skip the test
case with kernel v6.0 or older, applying the hunk below. Could you repost v2
with this change? Or if you want, I can apply it together with v1. Please let
me know your preference.
diff --git a/tests/nvme/039 b/tests/nvme/039
index e175055..ea626e3 100755
--- a/tests/nvme/039
+++ b/tests/nvme/039
@@ -14,6 +14,7 @@ QUICK=1
requires() {
_have_program nvme
+ _have_kver 6 1
_have_kernel_option FAULT_INJECTION && \
_have_kernel_option FAULT_INJECTION_DEBUG_FS
}
--
Shin'ichiro Kawasaki
