On Thu, Nov 10 2022 at 1:09P -0500, Mike Snitzer <snitzer@xxxxxxxxxx> wrote: > The concern for race aside: > I am concerned that your redundant bd_link_disk_holder() (first in > open_table_device and later in dm_setup_md_queue) will result in > dangling refcount (e.g. increase of 2 when it should only be by 1) -- > given bd_link_disk_holder will gladly just bump its holder->refcnt if > bd_find_holder_disk() returns an existing holder. This would occur if > a DM table is already loaded (and DM device's gendisk exists) and a > new DM table is being loaded. Nevermind, dm_setup_md_queue should only ever be called once.
