On Mon, Nov 07, 2022 at 12:16:22PM -0800, Eric Biggers wrote: > On Mon, Nov 07, 2022 at 03:42:27PM +0100, Christoph Hellwig wrote: > > diff --git a/block/blk-crypto.c b/block/blk-crypto.c > > index a496aaef85ba4..0e0c2fc56c428 100644 > > --- a/block/blk-crypto.c > > +++ b/block/blk-crypto.c > > @@ -357,17 +357,18 @@ int blk_crypto_init_key(struct blk_crypto_key *blk_key, const u8 *raw_key, > > * request queue it's submitted to supports inline crypto, or the > > * blk-crypto-fallback is enabled and supports the cfg). > > */ > > Replace "request queue" with block_device in the above comment? Done. > > - __blk_crypto_cfg_supported(q->crypto_profile, cfg); > > + __blk_crypto_cfg_supported(bdev_get_queue(bdev)->crypto_profile, > > + cfg); > > } > > There's a whitespace error here: Fixed. > > /* > > * If the request_queue didn't support the key, then blk-crypto-fallback > > * may have been used, so try to evict the key from blk-crypto-fallback. > > */ > > return blk_crypto_fallback_evict_key(key); > > Likewise, s/request_queue/block_device/ in the above comment. Done. > > struct request; > > struct request_queue; > > These forward declarations are no longer needed and can be removed. Done.
