On 11/7/22 11:20 PM, Christoph Hellwig wrote: > On Mon, Nov 07, 2022 at 09:20:37PM -0700, Jens Axboe wrote: >> Getting rid of the helper is nice, but the realloc one is badly >> named imho. Can we rename that while at it? There are only 1 >> caller after this anyway. > > Tell me your preferred name and I'll do it. Just call it blk_mq_alloc_tag_set_tags() at least and get rid of the realloc? Should make the patch simpler too. -- Jens Axboe