On 11/6/2022 4:50 PM, Damien Le Moal wrote: > Rename ata_rwcmd_protocol() to ata_set_rwcmd_protocol() to better > reflect the fact that this function sets a task file command and > protocol. The arguments order is also reversed and the function return > type changed to a bool to indicate if the command and protocol were set > corretly (instead of returning a completely arbitrary "-1" value. > > Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx> > Reviewed-by: Hannes Reinecke <hare@xxxxxxx> This definitely makes than -1.. Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx> -ck