On Wed, Nov 02, 2022 at 12:52:06AM +0000, Chaitanya Kulkarni wrote: >On 10/27/22 13:07, Vincent Fu wrote: >> On Wed, Oct 05, 2022 at 10:05:13PM -0700, Chaitanya Kulkarni wrote: >>> For a Zoned Block Device zone reset all is emulated if underlaying >>> device doesn't support REQ_OP_ZONE_RESET_ALL operation. In null_blk >>> Zoned mode there is no way to test zone reset all emulation present in >>> the block layer since we enable it by default :- >>> >>> blkdev_zone_mgmt() >>> blkdev_zone_reset_all_emulation() <--- >>> blkdev_zone_reset_all() >>> >>> Add a module parameter zone_reset_all to enable or disable >>> REQ_OP_ZONE_RESET_ALL, enable it by default to retain the existing >>> behaviour. >>> >>> Signed-off-by: Chaitanya Kulkarni <kch@xxxxxxxxxx> >> >> For the sake of completeness would it be reasonable to also provide a >> means to set this option via configfs? >> >> Vincent > >I deliberately avoided that as I don't see any need for it as of now. >but if it is a hard requirement I Can certainly send V2 with configfs >param. > >-ck I think the default should be to have features available as both module options and via configfs unless there are good reasons to make an exception. https://lore.kernel.org/linux-block/f0dadb60-c02d-d569-3004-81eafeebb95f@xxxxxxxxx/ https://lore.kernel.org/linux-block/ca206223-112f-2d60-34a3-bb7e6295de7a@xxxxxxxxx/ Vincent
