On Fri, Nov 04, 2022 at 06:46:20AM +0100, Christoph Hellwig wrote: > Each device driver that > wants to support inline encryption will construct a blk_crypto_profile, then > -associate it with the disk's request_queue. > +associate it with the block device. > [...] > -Once the driver registers a blk_crypto_profile with a request_queue, I/O > +Once the driver registers a blk_crypto_profile with a block_device, I/O > requests the driver receives via that queue may have an encryption context. [...] > -Request queue based layered devices like dm-rq that wish to support inline > -encryption need to create their own blk_crypto_profile for their request_queue, > +Request based layered devices like dm-rq that wish to support inline > +encryption need to create their own blk_crypto_profile for their block_device, > and expose whatever functionality they choose. When a layered device wants to [...] Shouldn't the three places above still say request_queue, not block_device? They're talking about the driver. - Eric