On 11/1/22 18:22, Ming Lei wrote:
On Tue, Nov 01, 2022 at 10:23:32AM -0700, Bart Van Assche wrote:
On 10/19/22 15:23, Bart Van Assche wrote:
Since multi-page bvecs are supported there can be multiple segments per
bvec (see also bvec_split_segs()). Hence this patch that calculates the
number of segments per bvec instead of assuming that there is only one
segment per bvec.
(replying to my own email)
Hi Ming,
Do you agree that this patch fixes a bug introduced by the multi-page bvec
code and also that it is required even if the segment size is larger than
the page size?
No, multi-age bvec is only applied on normal IO bvec, and it isn't used
in bio_add_pc_page(), so there isn't such issue in blk_rq_append_bio(),
that is why we needn't to split passthrough bio.
Hi Ming,
Thanks for the feedback. I will fix the description of this patch.
Bart.
