Re: [PATCH 4/4] blk-mq: improve readability of blk_mq_alloc_request()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> +static struct request *blk_mq_alloc_request_nocache(struct request_queue *q,
>> +		blk_opf_t opf, blk_mq_req_flags_t flags)
> 
> The name is a bit odd, but I can't think off a better one.
> 
>> +	struct blk_mq_alloc_data data = {
>>   			.q		= q,
>>   			.flags		= flags,
>>   			.cmd_flags	= opf,
>>   			.nr_tags	= 1,
>>   		};
> 
> And this now has superflous indenation.  Overall, while the separate
> helper looks marginally nicer, I'm not really sure it is worth the
> churn.

existing code is fine here than adding this indentation which
is not worth a churn...

-ck





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux