On 2022/10/29 09:04, Ming Lei wrote:
> UBLK_F_URING_CMD_COMP_IN_TASK needs to be set and returned to userspace
> if ublk driver is built as module, otherwise userspace may get wrong
> flags shown.
>
> Fixes: 71f28f3136af ("ublk_drv: add io_uring based userspace block driver")
> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>
> ---
> drivers/block/ublk_drv.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index 5afce6ffaadf..6b2f214f0d5c 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -1658,6 +1658,9 @@ static int ublk_ctrl_add_dev(struct io_uring_cmd *cmd)
> */
> ub->dev_info.flags &= UBLK_F_ALL;
>
> + if (!IS_BUILTIN(CONFIG_BLK_DEV_UBLK))
> + ub->dev_info.flags |= UBLK_F_URING_CMD_COMP_IN_TASK;
> +
> /* We are not ready to support zero copy */
> ub->dev_info.flags &= ~UBLK_F_SUPPORT_ZERO_COPY;
>
Reviewed-by: ZiyangZhang <ZiyangZhang@xxxxxxxxxxxxxxxxx>
