Re: [PATCH v3 11/19] nvme: Add pr_ops read_reservation support

To: Mike Christie <michael.christie@xxxxxxxxxx>
Subject: Re: [PATCH v3 11/19] nvme: Add pr_ops read_reservation support
From: Christoph Hellwig <hch@xxxxxx>
Date: Sun, 30 Oct 2022 09:18:51 +0100
Cc: bvanassche@xxxxxxx, hch@xxxxxx, martin.petersen@xxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, james.bottomley@xxxxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, snitzer@xxxxxxxxxx, axboe@xxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, chaitanyak@xxxxxxxxxx, kbusch@xxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx
In-reply-to: <20221026231945.6609-12-michael.christie@oracle.com>
References: <20221026231945.6609-1-michael.christie@oracle.com> <20221026231945.6609-12-michael.christie@oracle.com>
User-agent: Mutt/1.5.17 (2007-11-01)

> +	memset(resv, 0, sizeof(*resv));

Is there any good reason this isn't done by the caller?

Follow-Ups:
- Re: [PATCH v3 11/19] nvme: Add pr_ops read_reservation support
  - From: Mike Christie

References:
- [PATCH v3 00/19] Use block pr_ops in LIO
  - From: Mike Christie
- [PATCH v3 11/19] nvme: Add pr_ops read_reservation support
  - From: Mike Christie