Re: [PATCH 03/17] nvme-pci: don't warn about the lack of I/O queues for admin controllers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Admin controllers never have I/O queues, so don't warn about that fact.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
---
  drivers/nvme/host/pci.c | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 51513d263d77a..ec034d4dd9eff 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2917,7 +2917,8 @@ static void nvme_reset_work(struct work_struct *work)
  			nvme_dbbuf_set(dev);
  			nvme_unfreeze(&dev->ctrl);
  		} else {
-			dev_warn(dev->ctrl.device, "IO queues lost\n");
+			if (dev->ctrl.cntrltype != NVME_CTRL_ADMIN)
+				dev_warn(dev->ctrl.device, "IO queues lost\n");

I have a feeling that we have quite a few other messages that are
irrelevant for admin controllers. And I wander what device you have that
presents an admin controller, but looks good,

Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx>



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux